Re: Linux 3.6-rc6

[Fengguang Wu]

On Sat, Sep 22, 2012 at 11:57:23AM -0700, Linus Torvalds wrote:
> On Fri, Sep 21, 2012 at 5:59 PM, Shaun Ruffell <sruffell@xxxxxxxxxx> wrote:
> >
> > I posted patches [1,2,3] that resolve the issue for me. Shaohui Xie
> > also hit the issue and posted a slightly different patch [4]. The
> > patches are currently waiting for Mauro, who I understand is
> > catching up since returning from San Diego, to check them out.
> >
> > [1] http://marc.info/?l=linux-kernel&m=134764595921752&w=2
> > [2] http://marc.info/?l=linux-kernel&m=134764594721747&w=2
> > [3] http://marc.info/?l=linux-kernel&m=134764597921761&w=2
> > [4] http://marc.info/?l=linux-kernel&m=134753579818528&w=2
> 
> That first patch needs a sign-off from you, since you are passing on
> somebody elses patch.
> 
> Looking at that patch, the patch seems to be a memory leak (?) leaking
> the "channels" allocation, along with fixing an odd and incorrect

Yes.

> kfree (and access) of mci->csrows[i]. If that is correct, please write

Right.

> a proper changelog. The current changelog for that thing is totally
> pointless, and doesn't actually explain what the patch *does*.
 
Sorry I'll send the fix with more complete changelog in a standalone
patch for review.

> I'd also like some ack's from people, and I'd love to know which
> commit introduced the problem(s). If this problem is new to 3.6, I
> want to know what caused it, and if it is *not* new, then the thing
> needs to be marked for stable. Please?

It's a new bug to 3.6.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/