Re: [PATCH v2 7/9] ARM: OMAP: iommu: optimize save and restoreroutines

From: Tony Lindgren
Date: Tue Sep 18 2012 - 14:04:34 EST


* Omar Ramirez Luna <omar.luna@xxxxxxxxxx> [120912 12:47]:
> --- a/arch/arm/plat-omap/include/plat/iommu.h
> +++ b/arch/arm/plat-omap/include/plat/iommu.h
> @@ -27,6 +27,13 @@ struct iotlb_entry {
> };
> };
>
> +/* context registers */
> +struct iommu_regs {
> + u32 irqen;
> + u32 cntl;
> + u32 ttb;
> +};
> +
> struct omap_iommu {
> const char *name;
> struct module *owner;
> @@ -50,7 +57,8 @@ struct omap_iommu {
> struct list_head mmap;
> struct mutex mmap_lock; /* protect mmap */
>
> - void *ctx; /* iommu context: registres saved area */
> + struct iommu_regs context;
> + int ctx_loss_cnt;
> u32 da_start;
> u32 da_end;
> };
> --- a/arch/arm/plat-omap/include/plat/iommu2.h
> +++ b/arch/arm/plat-omap/include/plat/iommu2.h
> @@ -35,8 +35,6 @@
> #define MMU_READ_RAM 0x6c
> #define MMU_EMU_FAULT_AD 0x70
>
> -#define MMU_REG_SIZE 256
> -
> /*
> * MMU Register bit definitions
> */

These headers should be moved to include/linux/platform_data/iommu-omap.h
or something like that. Care to take care of that too?

I guess there's no reason to have both iommu.h and iommuh2.h?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/