Re: [PATCH 14/16] X.509: Add an ASN.1 decoder

From: Alan Cox
Date: Fri Sep 14 2012 - 05:35:28 EST


On Fri, 14 Sep 2012 00:50:05 +0100
David Howells <dhowells@xxxxxxxxxx> wrote:

> Add an ASN.1 BER/DER/CER decoder. This uses the bytecode from the ASN.1
> compiler in the previous patch to inform it as to what to expect to find in the
> encoded byte stream. The output from the compiler also tells it what functions
> to call on what tags, thus allowing the caller to retrieve information.

Why do this in the kernel.That appears to be completely insane. Can you
prove it runs in a short bounded time for all inputs, has it been fuzz
tested extensively ?

This kind of crap belongs in user space. Parse it in userspace, pass same
structures and objects to the kernel.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/