Re: [PATCH 3/5] staging: ipack: remove irq field in structipack_device.

From: Samuel Iglesias Gonsálvez
Date: Thu Sep 13 2012 - 06:32:09 EST


On Thu, 2012-09-13 at 13:01 +0300, Dan Carpenter wrote:
> On Thu, Sep 13, 2012 at 11:46:26AM +0200, Samuel Iglesias Gonsalvez wrote:
> > From: Jens Taprogge <jens.taprogge@xxxxxxxxxxxx>
> >
> > The field irq currently is identical to the slot number. It does not seem to
> > have any real use. The number is written to hardware in ipoctal but it seems
> > the value that is written does not matter.
> >
> > Signed-off-by: Jens Taprogge <jens.taprogge@xxxxxxxxxxxx>
> > Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@xxxxxxxxxx>
> > ---
> > - iowrite8(vector, ipoctal->dev->mem_space.address + 1);
> > + iowrite8(1, ipoctal->dev->mem_space.address + 1);
>
> It might be nice to put a /* dummy write */ comment here.
>

Added! Thanks for the suggestion,

Sam

Attachment: signature.asc
Description: This is a digitally signed message part