Re: [PATCH 3/5] staging: ipack: remove irq field in structipack_device.

[Dan Carpenter]

On Thu, Sep 13, 2012 at 11:46:26AM +0200, Samuel Iglesias Gonsalvez wrote:
> From: Jens Taprogge <jens.taprogge@xxxxxxxxxxxx>
> 
> The field irq currently is identical to the slot number.  It does not seem to
> have any real use.  The number is written to hardware in ipoctal but it seems
> the value that is written does not matter.
> 
> Signed-off-by: Jens Taprogge <jens.taprogge@xxxxxxxxxxxx>
> Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@xxxxxxxxxx>
> ---
> -	iowrite8(vector, ipoctal->dev->mem_space.address + 1);
> +	iowrite8(1, ipoctal->dev->mem_space.address + 1);

It might be nice to put a /* dummy write */ comment here.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/