Re: [PATCH] perf: Introduce function to report unsupported syscall attribute flags

From: Andi Kleen
Date: Wed Sep 12 2012 - 10:26:41 EST


Peter Zijlstra <peterz@xxxxxxxxxxxxx> writes:

> On Wed, 2012-09-12 at 13:01 +0200, Robert Richter wrote:
>> + if (notsup)
>> + pr_warn("perf: unsupported attribute flags: %016llx\n", notsup);
>
> This is a dmesg DoS..
>
> I'm also not sure dmesg is the right way.. could we not somehow change
> the attrs to provide better diagnostic?

Have a output argument for a string, that is then printed by the user tool?

I agree it's a problem today, i usually have to resort to ftrace to
figure out what'swrong.

-Andi

--
ak@xxxxxxxxxxxxxxx -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/