Re: [PATCH] perf: Introduce function to report unsupported syscallattribute flags

From: Robert Richter
Date: Wed Sep 12 2012 - 09:04:46 EST

On 12.09.12 13:20:43, Peter Zijlstra wrote:
> On Wed, 2012-09-12 at 13:01 +0200, Robert Richter wrote:
> > + if (notsup)
> > + pr_warn("perf: unsupported attribute flags: %016llx\n", notsup);
> This is a dmesg DoS..

This could be avoided by introducing a cpuinfo like sysfs file for
each pmu:


Then, userspace should know how to correctly setup the syscall. All
supported attributes would be known to perf and messages would thrown
only if something goes unexpected wrong.

I suggested this already here:

> I'm also not sure dmesg is the right way.. could we not somehow change
> the attrs to provide better diagnostic?

I found this discussion without a solution for the problem:

Other options could be pr_debug() or trace_printk()'s for debugging
purposes. Or an error report in sysfs:

cat /sys/bus/event_source/devices/*/log

But the pmu type needs to be known for this.


Advanced Micro Devices, Inc.
Operating System Research Center

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at