Re: [PATCH 13/16] ARM: omap: move platform_data definitions

From: Shilimkar, Santosh
Date: Tue Sep 11 2012 - 10:30:57 EST

On Tue, Sep 11, 2012 at 7:47 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Tuesday 11 September 2012, Shilimkar, Santosh wrote:
>> Just curious to know how you came with some of the above header names ?
>> plat/mcbsp ---> dsp-mcbsp.h
>> There is no connection of DSP with McBSP. "omap-mcbsp.h" would been a
>> better name.
> This one was a mistake on my side, as Tony and Peter already pointed out.
> How about asoc-mcbsp.h or asoc-omap-mcbsp.h?
After re-reading the cover-letter and your below response,
'asoc-omap-mcbsp.h' seems to be fine.

>> plat/nand.h --> /mtd-nand-omap2.h
>> plat/onenand.h --> /mtd-onenand-omap2.h
>> May be "omap-nand.h" and "omap-onenand.h"
>> plat/mcspi.h-->spi-omap2-mcspi.h
>> May be "omap-spi.h"
> As I wrote in the introductory mail, I tried to always prefix the file
> names with the subsystem, followed by the name of the driver, in order
> to standardize on just one set of rules.
Just read that now.

> The drivers implementing the three headers above are:
> drivers/mtd/nand/omap2.c
> drivers/mtd/onenand/omap2.c
> drivers/spi/spi-omap2-mcspi.c
> so these all seem appropriate.
Sorry I missed the subsystem prefix point.
These names seems to be fine then.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at