Re: [PATCH 00/19] First HREF Device Tree enablement patch-set

From: Linus Walleij
Date: Mon Sep 10 2012 - 07:29:34 EST


On Mon, Sep 10, 2012 at 3:13 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:

> I think it's fine to do the device driver conversion separately
> from the platform changes, but doing that properly means that the
> platform changes should only go in after the drivers have changed.

OK, in the diffstat we're discussing we have this:

drivers/gpio/gpio-tc3589x.c | 120 +++++++++++++++++++--------
drivers/i2c/busses/i2c-nomadik.c | 4 +
drivers/mfd/mfd-core.c | 10 ++-
drivers/mfd/tc3589x.c | 112 +++++++++++++++++++------
include/linux/mfd/tc3589x.h | 1 +

> Inside of the platform code, I absolutely think we should change the
> board file and the dts file simultaneously.

Sure, no problem. But this patch series might have a title
problem, as it is not isolated to the platform code at all.

> When the driver offers
> two ways of probing a device, this lets us change from one way to
> the other without going through a phase where we use neither of them
> or (worse) both at the same time.

Maybe unrelated, but as usual it works as long as there are no
DMA channels or callback functions :-/

The MMC, PL022 patches in this patch set: both need
AUXDATA and DT data simultaneously due to DMA channels
and callbacks passed in as AUXDATA.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/