RE: [PATCH][v3] sata_fsl: add workaround for data length mismatchon freescale V2 controller

From: Xie Shaohui-B21989
Date: Mon Sep 10 2012 - 06:46:01 EST


> -----Original Message-----
> From: Sergei Shtylyov [mailto:sshtylyov@xxxxxxxxxx]
> Sent: Monday, September 10, 2012 6:22 PM
> To: Xie Shaohui-B21989
> Cc: Kumar Gala; jgarzik@xxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx; linuxppc-
> dev@xxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Bhartiya Anju-B07263
> Subject: Re: [PATCH][v3] sata_fsl: add workaround for data length
> mismatch on freescale V2 controller
>
> Hello.
>
> On 10-09-2012 6:53, Xie Shaohui-B21989 wrote:
>
> >>> + /* Workaround for data length mismatch errata */
> >>> + if (unlikely(hstatus & INT_ON_DATA_LENGTH_MISMATCH)) {
> >>> + for (tag = 0; tag < ATA_MAX_QUEUE; tag++) {
> >>> + qc = ata_qc_from_tag(ap, tag);
> >>> + if (qc && ata_is_atapi(qc->tf.protocol)) {
> >>> + u32 hcontrol;
> >>> +#define HCONTROL_CLEAR_ERROR (1 << 27)
>
> >> shouldn't we have this #define be part of the enum that the other
> >> HCONTROL_ bits/flags are part of?
>
> > [S.H] do you mean this?
>
> Apparently not. He said *enum*, not #define.

[S.H] OK. Thank you for the clarification.


Best Regards,
Shaohui Xie

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/