Re: [PATCH] PCI: drop duplicate const in DECLARE_PCI_FIXUP_SECTION

From: Mathias Krause
Date: Sun Sep 09 2012 - 12:55:44 EST


On Sun, Sep 2, 2012 at 11:37 PM, Mathias Krause <minipli@xxxxxxxxxxxxxx> wrote:
> It's redundant and makes sparse complain about it.
>
> Signed-off-by: Mathias Krause <minipli@xxxxxxxxxxxxxx>
> ---
> include/linux/pci.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 5faa831..aee24a8 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -1472,7 +1472,7 @@ enum pci_fixup_pass {
> /* Anonymous variables would be nice... */
> #define DECLARE_PCI_FIXUP_SECTION(section, name, vendor, device, class, \
> class_shift, hook) \
> - static const struct pci_fixup const __pci_fixup_##name __used \
> + static const struct pci_fixup __pci_fixup_##name __used \
> __attribute__((__section__(#section), aligned((sizeof(void *))))) \
> = { vendor, device, class, class_shift, hook };
>
> --
> 1.7.10.4
>

Ping? It's janitor work, but hey, it fixes a sparse warning.

Mathias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/