RE: [PATCH] KVM: tsc deadline timer works only when hrtimer highresolution configured

[Liu, Jinsong]

 Avi Kivity wrote:
> On 09/09/2012 05:54 PM, Liu, Jinsong wrote:
>>> 
>>> hrtimers is an intrusive feature, I don't think we should
>>> force-enable it.  Please change it to a depends on.
>> 
>> Hmm, if it changed as
>> config KVM
>> 	depends on HIGH_RES_TIMERS
>> The item 'Kernel-based Virtual Machine (KVM) support (NEW)' even
>> didn't appear to user when make menuconfig (when HIGH_RES_TIMERS
>> disable)  
>> 
>> Is it good? I just have a little concern here:)
> 
> It's not good, but that's what we have.
> 
> It's okay to force-enable low-impact features (like preempt notifies).
> 
> hrimers, on the other hand, change kernel behaviour quite deeply.
> 
> Maybe over time someone will fix the config tools to unhide features
> that can be enabled by turning on a dependency.

OK, updated as attached.

Thanks,
Jinsong

===============