Re: [PATCH 4/7 V6] workqueue: fix idle worker depletion

From: Tejun Heo
Date: Sun Sep 09 2012 - 02:31:22 EST


Hello, Lai.

On Sun, Sep 09, 2012 at 12:09:58PM +0800, Lai Jiangshan wrote:
> > mutex_lock(&pool->manager_mutex);
> > if (worker_maybe_bind_and_lock(worker))
> > worker_clr_flags(worker, WORKER_UNBOUND);
> > ret = true;
> >
>
>
> This code is correct. worker_maybe_bind_and_lock() can be called any time.
> but I like to call it only when it is really needed.

Ummm... that code is complex for no reason. It isn't easier to read
or better in any way. Given the recent exchanges, it seems our tastes
differ greatly. Can you please just refresh the two patches as
requested and repost them on top of for-3.6-fixes?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/