Re: [PATCH mmotm] slub: zero page to fix boot crashes

[Christoph]

Yes that fix was already sent by me.



On Sep 8, 2012, at 22:42, Hugh Dickins <hughd@xxxxxxxxxx> wrote:

> Latest mmotm rarely boots if SLUB is enabled: earlyprintk=vga shows
> it crashing with various backtraces.  The memset has now been removed
> from kmem_cache_open(), so kmem_cache_init() needs to zero its page.
> This gets SLUB booting reliably again.
> 
> Signed-off-by: Hugh Dickins <hughd@xxxxxxxxxx>
> ---
> 
> mm/slub.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- mmotm/mm/slub.c    2012-09-07 12:39:38.136019730 -0700
> +++ fixed/mm/slub.c    2012-09-08 19:37:38.608993123 -0700
> @@ -3712,7 +3712,7 @@ void __init kmem_cache_init(void)
>    /* Allocate two kmem_caches from the page allocator */
>    kmalloc_size = ALIGN(kmem_size, cache_line_size());
>    order = get_order(2 * kmalloc_size);
> -    kmem_cache = (void *)__get_free_pages(GFP_NOWAIT, order);
> +    kmem_cache = (void *)__get_free_pages(GFP_NOWAIT | __GFP_ZERO, order);
> 
>    /*
>     * Must first have the slab cache available for the allocations of the
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/