Re: [PATCH 00/36] AutoNUMA24

[Ingo Molnar]

* Andrea Arcangeli <aarcange@xxxxxxxxxx> wrote:

> On Wed, Aug 22, 2012 at 11:40:48PM +0200, Ingo Molnar wrote:
> > 
> > * Rik van Riel <riel@xxxxxxxxxx> wrote:
> > 
> > > On 08/22/2012 10:58 AM, Andrea Arcangeli wrote:
> > > >Hello everyone,
> > > >
> > > >Before the Kernel Summit, I think it's good idea to post a new
> > > >AutoNUMA24 and to go through a new review cycle. The last review cycle
> > > >has been fundamental in improving the patchset. Thanks!
> > > 
> > > Thanks for improving the code and incorporating all our 
> > > feedback. The AutoNUMA codebase is now in a state where I can 
> > > live with it.
> > > 
> > > I hope the code will be acceptable to others, too.
> > 
> > Lots of scheduler changes. Has all of peterz's review feedback 
> > been addressed?
> 
> git diff --stat origin kernel/sched/
>  kernel/sched/Makefile |    1 +
>  kernel/sched/core.c   |    1 +
>  kernel/sched/fair.c   |   86 ++++++-
>  kernel/sched/numa.c   |  604 +++++++++++++++++++++++++++++++++++++++++++++++++
>  kernel/sched/sched.h  |   19 ++
>  5 files changed, 699 insertions(+), 12 deletions(-)
> 
> Lots of scheduler changes only if CONFIG_AUTONUMA=y.

That's a lot of scheduler changes.

> [...] If CONFIG_AUTONUMA=n it's just 107 lines of scheduler 
> changes (numa.c won't get built in that case).
> 
> > Hm, he isn't even Cc:-ed, how is that supposed to work?
> 
> I separately forwarded him the announcement email because I 
> wanted to add a few more (minor) details for him. Of course 
> Peter's review is fundamental and appreciated and already 
> helped to make the code a lot better.

I see no reason why such details shouldn't be discussed openly 
and why forwarding him things separately should cause you to 
drop a scheduler co-maintainer from the Cc:, with a 700 lines 
kernel/sched/ diffstat ...

> His previous comments should have been addressed, [...]

That's good news. Peter?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/