Re: [RFC/PATCH 02/13] serial: omap: always return IRQ_HANDLED

From: Felipe Balbi
Date: Tue Aug 21 2012 - 07:58:19 EST


On Tue, Aug 21, 2012 at 12:50:05PM +0100, Alan Cox wrote:
> On Tue, 21 Aug 2012 12:15:44 +0300
> Felipe Balbi <balbi@xxxxxx> wrote:
>
> > Even if we enter our IRQ handler just to notice
> > that the our device didn't generate the IRQ,
> > that still means "handling" and IRQ, so let's
> > return IRQ_HANDLED.
>
> That looks wrong - you'll defeat the stuck IRQ protection. If we didn't
> cause the IRQ then we are IRQ_NONE ?

that's true. I'll drop this patch from the list. My bad.

--
balbi

Attachment: signature.asc
Description: Digital signature