Re: [RFC/PATCH 02/13] serial: omap: always return IRQ_HANDLED

From: Alan Cox
Date: Tue Aug 21 2012 - 07:32:51 EST


On Tue, 21 Aug 2012 12:15:44 +0300
Felipe Balbi <balbi@xxxxxx> wrote:

> Even if we enter our IRQ handler just to notice
> that the our device didn't generate the IRQ,
> that still means "handling" and IRQ, so let's
> return IRQ_HANDLED.

That looks wrong - you'll defeat the stuck IRQ protection. If we didn't
cause the IRQ then we are IRQ_NONE ?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/