Re: [PATCH 0/5] mfd: replace IORESOURCE_IO by IORESOURCE_MEM

From: Haojian Zhuang
Date: Mon Aug 06 2012 - 10:42:07 EST


On Mon, Aug 6, 2012 at 10:30 PM, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> On Mon, Aug 06, 2012 at 12:32:48AM +0800, Haojian Zhuang wrote:
>
>> Since IORESOURCE_IO is used for PCI devices, it doesn't fit on
>> 88PM860x PMIC device that lies on I2C bus. So use IORESOURCE_MEM
>> instead.
>
> This isn't much more appropriate - _MEM is for memory ranges so isn't
> directly relevant to register addresses either. If anything _IO is
> slightly nearer.

I use register resource to distinguish different components now. For
example, component driver
needs to access the registers in PMIC. These registers offsets are set
in 88pm860x-core.c.
So I think that it may not be called _IO.

Regards
Haojian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/