Re: [PATCH] kbuild: kvm: make export of linux/kvm_para.hunconditional

[Sam Ravnborg]

On Fri, Aug 03, 2012 at 01:51:44PM +0100, Will Deacon wrote:
> On Thu, Aug 02, 2012 at 09:29:11PM +0100, Sam Ravnborg wrote:
> > On Thu, Aug 02, 2012 at 05:19:20PM +0300, Avi Kivity wrote:
> > > Can you get it reviewed by someone who is familiar with this?  This is
> > > probably the third fix for the this issue.
> > 
> > IMO the patch is wrong.
> > Any use of wildcards in include/asm-generic/Kbuild.asm is wrong.
> 
> I agree that the wildcard stuff is horrible but that's not something
> introduced by this patch. In fact, I'm removing those where there is an
> asm-generic header that can be used instead.
> 
> > IMO include/asm-generic/Kbuild.asm is for generic header files
> > that ALL archs can use.
> > 
> > If not ALL archs can use it, then the individual arch shall
> > specify the file explicit.
> 
> In which case, we should probably fix the rules for kvm.h and a.out.h as
> well. Neither of these headers have asm-generic versions and I doubt this
> is possible, so the header-y lines should be done for each architecture
> exporting such a header, no?
> 
> > I know we here hit a bad thing with the generic-y support,
> > where we miss a good way to add a file to a lot of archs
> > without editing a lot of files.
> 
> If there isn't a generic version of the header, then yes, I guess you have
> to modify the architectures that want to export it.
> 
> I'm happy to post an extra patch sorting out kvm.h and a.out.h if that's
> what's required to get headers building again.

IMO this is required to sort this out for good.
I will be happy to review your patches.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/