Re: [PATCH 0/6] menuconfig: jump to search results

[Yann E. MORIN]

All,

On Thursday 02 August 2012 16:18:47 Benjamin Poirier wrote:
> On 2012/08/02 15:32, Borislav Petkov wrote:
> > On Tue, Jul 31, 2012 at 09:17:51AM -0400, Benjamin Poirier wrote:
> > > > * when searching for "DELAY" for example, I get results without numbers
> > > > to which I can't jump to:
> > > > 
> > > > ...
> > > >   â Symbol: DEFAULT_IO_DELAY_TYPE [=0]
> > > >   â Type  : integer
> > > >   â
> > > >   â
> > > >   â Symbol: IO_DELAY_TYPE_0X80 [=0]
> > > >   â Type  : integer
> > > > ...
> > > > 
> > > > maybe because they don't have "---help---" section?
> > > 
> > > Because they don't have a prompt - they don't appear in any menu at all.
> > > In that case there's nowhere to jump to. That's why those symbols don't
> > > get a number.
> > 
> > Right, so how about you don't show them at all then?
> 
> It's a search for CONFIG_ symbols not "menus". Even though the user
> doesn't have direct control over some symbols, it's still useful to know
> they exist and (possibly) what enables them. For example, searching for
> LOCKDEP tells me I can enable DEBUG_LOCK_ALLOC to get it.

Agreed.

Consider this (very simple) situation :

    config A
        bool "A"
        select B

    config B
        bool

    config C
        bool "C"
        depends on B

Returning the symbol B in the search results allows to:
  - see its dependencies           -> to see why it is thus set
  - see in what file it is defined -> to change the deps and/or selects

So, yes, returning prompt-less symbols as search results is important.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/