Re: [PATCH] uprobes: Ignore unsupported instructions in uprobe_mmap

[Oleg Nesterov]

Forgot to mention...

On 08/02, Srikar Dronamraju wrote:
>
> While at it, add a missing put_uprobe() in the path where uprobe_mmap()
> races with uprobe_unregister().
> ...
> @@ -1051,8 +1051,10 @@ int uprobe_mmap(struct vm_area_struct *vma)
>  			if (ret == -EEXIST) {
>  				ret = 0;
>
> -				if (!is_swbp_at_addr(vma->vm_mm, vaddr))
> +				if (!is_swbp_at_addr(vma->vm_mm, vaddr)) {
> +					put_uprobe(uprobe);
>  					continue;
> +				}

Yes, this part looks correct.

In fact, I think this is not really correct anyway (wrt counter)
but we are going to kill it.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/