Re: [PATCH] Fix priority of non-BAR ROM data

From: Bjorn Helgaas
Date: Wed Aug 01 2012 - 10:21:08 EST


On Sun, Jul 29, 2012 at 3:53 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote:
> On Sun, Jul 29, 2012 at 10:49:42PM +0100, David Woodhouse wrote:
>> + * Some devices may provide ROMs via a source other than the BAR
>> + */
>> + if (pdev->rom && pdev->romlen) {
>> + *size = pdev->romlen;
>> + return phys_to_virt(pdev->rom);
>
> Needs casting. My mistake.

Matthew, are you going to fold this into your patch and repost your
series, or is this a logically separate issue?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/