Re: [RFC][PATCH v2 0/3] efi_pstore: avoid losing critical message

From: Matthew Garrett
Date: Mon Jul 23 2012 - 10:13:34 EST

On Thu, Jul 19, 2012 at 09:11:44PM +0000, Seiji Aguchi wrote:

> [Patch Descriptions]
> Patch 1/3 and 2/3 take fist approach, _not_ overwriting entries.
> Patch 3/3 takes second approach, adding some logic overwriting entries.
> 1/3: Avoid overwriting existing entry
> This patch just avoid overwriting entries to save the 1st critical message
> without being influenced by subsequent events.

I think there's a good argument in favour of this approach. Userspace
crash report tools should be taught to copy the crash data and then
remove the existing entries. It avoids any of the complexity associated
with other approaches and ensures that behaviour is always consistent.

Matthew Garrett | mjg59@xxxxxxxxxxxxx
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at