Re: [PATCH v2] leds: add new lp8788 led driver

From: Mark Brown
Date: Sun Jul 22 2012 - 14:20:07 EST

On Sat, Jul 21, 2012 at 02:48:49AM +0800, Bryan Wu wrote:

> Actually cancel_work_sync() is quite similar to flush_work_sync()
> here. For the timer thing, in fact it is NULL when cancel_work_sync()
> call __cancel_work_timer().

> And Mark, do you have any advice about the flush_work_sync() and
> cancel_work_sync(). I saw you use flush in the
> drivers/leds/leds-wm8350.c.

If the work is flushed then the state that userspace thought was set
when the driver is removed will actually be set before the driver is
removed. This is fairly minor but might be useful.

Attachment: signature.asc
Description: Digital signature