Re: [PATCH] mmc: omap_hsmmc: ensure probe returns error upon resource failure

From: Chris Ball
Date: Sat Jul 21 2012 - 19:23:43 EST


On Thu, Jul 12 2012, S, Venkatraman wrote:
> On Wed, Jul 11, 2012 at 5:10 AM, Kevin Hilman <khilman@xxxxxx> wrote:
>> If platform_get_resource_by_name() fails, driver probe is aborted an
>> should return an error so the driver is not bound to the device.
>> However, in the current error path of platform_get_resource_by_name(),
>> probe returns zero since the return value (ret) is not properly set.
>> With a zero return value, the driver core assumes probe was successful
>> and will bind the driver to the device.
>> Fix this by ensuring that probe returns an error code in this failure
>> path.
>> Signed-off-by: Kevin Hilman <khilman@xxxxxx>
> Good catch.
> Acked-by: Venkatraman S <svenkatr@xxxxxx>

Thanks, pushed to mmc-next for 3.6.

- Chris.
Chris Ball <cjb@xxxxxxxxxx> <>
One Laptop Per Child
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at