Re: [PATCH] kvm: fix race with level interrupts
From: Michael S. Tsirkin
Date: Thu Jul 19 2012 - 08:09:56 EST
On Thu, Jul 19, 2012 at 06:06:31AM -0600, Alex Williamson wrote:
> On Thu, 2012-07-19 at 12:15 +0300, Michael S. Tsirkin wrote:
> > On Wed, Jul 18, 2012 at 05:22:42PM -0600, Alex Williamson wrote:
> > > I hate reviewing code
> > > > > where I have to differentiate 'l' vs '1'.
> > > >
> > > > l is an illegal variable name? Switch to a different font.
> > >
> > > WTF
> > Really, you should use a font where these differ. I currently use
> > Monospace but there are many other good fonts. If you don't bugs sneak
> > in.
> > int x = 11;
> > and
> > int x = 1l;
> > Should look very different.
> Don't be an asshole, my dog could tell the difference between those
> side-by-side. That's not what you posted. I use monospace as well and
> find it offensive that you suggest someone change fonts to review your
> code. Clearly, any time spent trying to identify a single character in
> isolation is not well spent.
I apologize for offending you, this was not my intent.
I sent v2 to address your comments, thanks.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/