Re: [PATCH V2 1/6] mfd: tps6586x:use devm managed resources

From: Laxman Dewangan
Date: Tue Jul 17 2012 - 00:50:51 EST

On Tuesday 17 July 2012 01:31 AM, Mark Brown wrote:
On Mon, Jul 16, 2012 at 12:21:45PM +0530, Laxman Dewangan wrote:

- ret = request_threaded_irq(irq, NULL, tps6586x_irq, IRQF_ONESHOT,
- "tps6586x", tps6586x);
+ ret = devm_request_threaded_irq(tps6586x->dev, irq, NULL, tps6586x_irq,
+ IRQF_ONESHOT, "tps6586x", tps6586x);
Are you sure this is safe - what guarantees that we can't get an
interrupt while tearing the device down?

I think device_remove will get called before the managed resource get freed.
So do we need to call disable_irq() in remove() to avoid any interrupts?

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at