Re: [PATCH V2 1/6] mfd: tps6586x:use devm managed resources

From: Mark Brown
Date: Mon Jul 16 2012 - 16:01:10 EST


On Mon, Jul 16, 2012 at 12:21:45PM +0530, Laxman Dewangan wrote:

> - ret = request_threaded_irq(irq, NULL, tps6586x_irq, IRQF_ONESHOT,
> - "tps6586x", tps6586x);
> + ret = devm_request_threaded_irq(tps6586x->dev, irq, NULL, tps6586x_irq,
> + IRQF_ONESHOT, "tps6586x", tps6586x);

Are you sure this is safe - what guarantees that we can't get an
interrupt while tearing the device down?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/