Re: [PATCH] staging: comedi: fix Kconfig for COMEDI_PCMCIA_DRIVERS

[Ian Abbott]

On 2012-06-15 17:18, H Hartley Sweeten wrote:
> The depends on PCCARD is redundant. All of the comedi PCMCIA
> drivers depend on PCMCIA which can only be enabled if PCCARD
> is enabled. Remove the extra depends check.
>
> Signed-off-by: H Hartley Sweeten<hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Ian Abbott<abbotti@xxxxxxxxx>
> Cc: Frank Mori Hess<fmhess@xxxxxxxxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman<gregkh@xxxxxxxxxxxxxxxxxx>

I tested it with Randy's config from

  Subject: Re: linux-next: Tree for Jun 14 (staging/comedi)
  Message-ID: <4FDA59D7.3050200@xxxxxxxxxxxx>

and `make oldconfig` no longer leaves CONFIG_COMEDI_NI_LABPC_CS, etc. 
defined, so it seems to work!

Thanks.

Tested-by: Ian Abbott <abbotti@xxxxxxxxx>

> ---
>   drivers/staging/comedi/Kconfig |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/comedi/Kconfig b/drivers/staging/comedi/Kconfig
> index 848cf7e..2ca7f08 100644
> --- a/drivers/staging/comedi/Kconfig
> +++ b/drivers/staging/comedi/Kconfig
> @@ -1097,7 +1097,7 @@ endif # COMEDI_PCI_DRIVERS
>
>   menuconfig COMEDI_PCMCIA_DRIVERS
>   	tristate "Comedi PCMCIA drivers"
> -	depends on (PCMCIA || PCCARD)
> +	depends on PCMCIA
>   	---help---
>   	  Enable comedi PCMCIA and PCCARD drivers to be built


--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/