Re: [tip:x86/platform] x86/vsmp: Ignore IOAPIC IRQ affinity ifpossible

From: Ingo Molnar
Date: Thu Jun 14 2012 - 06:51:33 EST



* Ido Yariv <ido@xxxxxxxxxx> wrote:

> Hi Ingo,
>
> On Mon, Jun 11, 2012 at 10:58:43AM +0200, Ingo Molnar wrote:
> >
> > * Ido Yariv <ido@xxxxxxxxxx> wrote:
> >
> > > This seems to break when CONFIG_PARAVIRT is set but CONFIG_SMP
> > > isn't. Since there's little point in optimizing IOAPIC routing
> > > for UP kernels, how about the following fix?
> >
> > Looks good to me, I'll give it some testing.
>
> I'm afraid this patch is missing one more config dependency. Since
> no_irq_affinity is declared in proc.c, we need to verify that
> CONFIG_PROC_FS is set before referencing this variable. The below patch
> fixes this.
>
> Thanks to Fengguang Wu for reporting this.

Please send a delta fix patch on top of latest -tip to fix this.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/