Re: [tip:x86/platform] x86/vsmp: Ignore IOAPIC IRQ affinity ifpossible

From: Ido Yariv
Date: Mon Jun 11 2012 - 15:41:22 EST


Hi Ingo,

On Mon, Jun 11, 2012 at 10:58:43AM +0200, Ingo Molnar wrote:
>
> * Ido Yariv <ido@xxxxxxxxxx> wrote:
>
> > This seems to break when CONFIG_PARAVIRT is set but CONFIG_SMP
> > isn't. Since there's little point in optimizing IOAPIC routing
> > for UP kernels, how about the following fix?
>
> Looks good to me, I'll give it some testing.

I'm afraid this patch is missing one more config dependency. Since
no_irq_affinity is declared in proc.c, we need to verify that
CONFIG_PROC_FS is set before referencing this variable. The below patch
fixes this.

Thanks to Fengguang Wu for reporting this.

Thanks,
Ido.