Re: [alsa-devel] [PATCH v5] sound/soc/lapis: add platform driver for ML7213

From: Tomoya MORINAGA
Date: Wed Jun 13 2012 - 06:42:03 EST


On Mon, Jun 11, 2012 at 5:54 PM, Mark Brown
<broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
> There are some drivers that predate the availibility of the dmaengine
> framework.

In case, you develop a new ASoC framework, all previous ASoC drivers
should be adopted to the framework by yourself, don't you ?
Because a new developer must be confused by this.

> This, and the fact that the PCH driver uses dmaengine without using any
> shared code, is the topic of the discussion.  It is entirely natural
> that there are no open coded drivers using cyclic DMA via dmaengine,
> they have all had that code factored out.
>
> Please stop this and at least look at factoring this code out.  If it
> turns out that there's some reason why it's a lot of work that's one
> thing but it seems clear that you've not even looked yet.  It's like the
> previous issues where you were sending patches which would clearly not
> run successfully, it's not a very positive approach.

OK, I'll stop this.

I wanted to finish adding these patch series to upstream because we
spent much resource on this.
But I'm involved in other work, so I can't start now.

Until now thank you for your support.
Regards.

--
ROHM Co., Ltd.
tomoya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/