Re: [PATCH 2/3] tools lib traceevent: Introduce pevent_errno

From: Steven Rostedt
Date: Tue Jun 12 2012 - 13:57:36 EST


On Tue, 2012-06-12 at 16:42 +0900, Namhyung Kim wrote:
> From: Namhyung Kim <namhyung.kim@xxxxxxx>
>
> Define and use error numbers for pevent_parse_event()
> and get rid of die() and do_warning() calls. If the
> function returns non-zero value, the caller can check
> the return code and do appropriate things.
>
> I chose the error numbers to be negative not to clash
> with standard errno, and as usual, 0 for success.
>
> Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>

Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

- Steve

> Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> ---
> tools/lib/traceevent/event-parse.c | 50 +++++++++++++++++++++---------------
> tools/lib/traceevent/event-parse.h | 26 +++++++++++++++++--
> 2 files changed, 54 insertions(+), 22 deletions(-)
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/