Re: [PATCH 3/3] staging: sm7xxfb: sm7xx becomes sm7xxfb

From: Greg KH
Date: Tue Jun 12 2012 - 13:55:10 EST


On Sun, Jun 10, 2012 at 01:25:51PM +0200, Javier Muñoz wrote:
> On 06/10/2012 01:12 PM, Javier M. Mellid wrote:
> > From: "Javier M. Mellid" <jmunhoz@xxxxxxxxxx>
> >
> > Rename sm7xx driver to sm7xxfb. Fix Kconfig and Makefile to fit the new
> > change.
> >
> > Changes are coherent with the rest of stable framebuffer drivers. TODO
> > updated.
>
> Just one doubt. I am using 'git mv' here and it works Ok. 'git log
> --follow' would be the way to see the whole history after this commit.
> Should I follow another approach? I am using a 'similar approach' to
> ed16648eb5b86917f0b90bdcdbc857202da72f90 commit to rename.
>
> Please, let me know if I should redo this patch.

When I apply it, git will detect the file being moved.

Also, patch, and git, now support renames when generating patches, you
should use that and it will be a bit more obvious that this really is
just a rename.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/