Re: [PATCH] pinctrl: nomadik: fix up typo

From: Lee Jones
Date: Tue Jun 12 2012 - 07:08:39 EST


On 12/06/12 11:56, Linus Walleij wrote:
Commit a60b57eddaa8af6c02cf7bbeb58ebf82881f08ac
"drivers/gpio: gpio-nomadik: Add support for irqdomains"
changed GPIO offset calculations to have this form:
(gpio % NMK_GPIO_PER_CHIP) except in this one place for
setting sleep mode, where the conversion was all wrong, and
instead mod:ing the GPIO with the IRQ base which does not
make any sense.

So fix this up so we can use sleepmode.

Cc: Lee Jones<lee.jones@xxxxxxxxxx>
Signed-off-by: Linus Walleij<linus.walleij@xxxxxxxxxxxxxx>

Makes sense.

Reviewed-by: Lee Jones <lee.jones@xxxxxxxxxx>

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/