Re: Clock register in early init

From: Turquette, Mike
Date: Thu May 24 2012 - 11:51:27 EST


On Wed, May 23, 2012 at 6:02 PM, Paul Mundt <lethal@xxxxxxxxxxxx> wrote:
> On Tue, May 22, 2012 at 10:37:15AM -0700, Turquette, Mike wrote:
>> On Tue, May 22, 2012 at 5:08 AM, Peter De Schrijver
>> <pdeschrijver@xxxxxxxxxx> wrote:
>> >> We had at-least that on the older Samsung parts and they where still
>> >> growing. I would suggest that in a multi-kernel image situation the
>> >> more data that can be discarded after init-time the better.
>> >>
>> >> Also, __initdata gets gathered into one place so there's no possibility
>> >> of page fragmentation there. If you mean fragmentation of the memory
>> >> map, then allocate the size of all the clocks you know of at init time
>> >> in one go.
>> >>
>> >
>> > That would work, except that clocks are needed before kmalloc is available.
>> >
>>
>> Is static initialization the only way to solve this problem?  What
>> about using the bootmem allocator for early init clocks?
>>
> This is what sh does for its asm/clkdev.h __clkdev_alloc(), which is
> really the only difference over the ARM version. It always seemed a bit
> silly to me to make early allocation an arch-specific property.

Good point. clkdev will probably need to be bootmem-able as well as
the common clk stuff.

Regards,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/