Re: [PATCH 2/5] regulator: tps65910: set of_node for regulatorregister config

From: Mark Brown
Date: Sat May 19 2012 - 13:48:28 EST


On Sat, May 19, 2012 at 08:04:07PM +0530, Laxman Dewangan wrote:

> set of_node parameter for regulator registration configuration
> parameter. This node contains the regulator related device node
> information for regulator which need to be register.

This isn't adding setting of the of_node...

> -#ifdef CONFIG_OF
> - config.of_node = of_find_node_by_name(tps65910->dev->of_node,
> + if (reg_node)
> + config.of_node = of_find_node_by_name(reg_node,
> info->name);
> -#endif

...it's changing the value that's being configured. The changelog
doesn't explain why this is being done.

Also, why is the ifdef being removed - won't that break the build?

Attachment: signature.asc
Description: Digital signature