Re: [PATCH 1/3] drivers:Fixed C99 comment issue.

[Greg KH]

Ok, now I'm going to get picky, so you can get this right and I will
have no excuse to reject your patches :)

First off, your subject: is "odd". You need to specify what you did
better, with a prefix that says so.

So, for this example, it should say:
	Subject: [PATCH 1/3] USB: storage: fixed c99 comment issue

See the "USB: storage:" part?  Having a generic "drivers:" like you did
really doesn't say anything, as over half of the kernel is drivers, and
you really didn't do this for all of that codebase :)

On Wed, May 16, 2012 at 01:02:15AM +0530, Jeffrin Jose wrote:
> Fixed C99 comment issue in drivers/usb/storage/usb.c
> found using checkpatch.pl tool.
> Signed-off-by: Jeffrin Jose <ahiliation@xxxxxxxxxxx>

You need an extra line before the Signed-off-by: line above.

Care to make these changes to all three of your patches and resend them?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/