Re: [PATCH v3] iio: add LM3533 ambient-light-sensor driver

From: Jonathan Cameron
Date: Tue May 15 2012 - 16:16:36 EST


On 05/15/2012 09:00 PM, Johan Hovold wrote:
> On Tue, May 15, 2012 at 12:27:05PM -0700, Andrew Morton wrote:
>> On Tue, 15 May 2012 18:46:36 +0200
>> Johan Hovold <jhovold@xxxxxxxxx> wrote:
>>
>>> Add sub-driver for the ambient-light-sensor interface on National
>>> Semiconductor / TI LM3533 lighting power chips.
>>>
>>> The sensor interface can be used to control the LEDs and backlights of
>>> the chip through defining five light zones and three sets of
>>> corresponding brightness target levels.
>>>
>>> The driver provides raw and mean adc readings along with the current
>>> light zone through sysfs. A threshold event can be generated on zone
>>> changes.
>>>
>>> ...
>>>
>>> drivers/staging/iio/light/Kconfig | 16 +
>>> drivers/staging/iio/light/Makefile | 1 +
>>> drivers/staging/iio/light/lm3533-als.c | 726 ++++++++++++++++++++
>>
>> Why is this aimed at drivers/staging/, rather than directly into
>> drivers/iio/?
>
> I understood it as it was only iio core which was moving out of staging
> in 3.5, but I see now that some drivers have been added directly to
> driver/iio. My mistake.
It was more a case that the core was the priority. Drivers would if
ready and people had time to do the patches!
>
> I'll make sure to move it to drivers/iio/light.
Yup, that's sensible for a new driver like this. I'll be even fussier
about the userspace interfaces though ;)

>
> Thanks for pointing it out,
> Johan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/