Re: [PATCH v4 7/7] x86/tlb: add tlb_flushall_factor into sysfs foruser testing/tuning

[Alex Shi]

> Nowhere do you say this is x86 only, please fix that.


sure.

> 
> Yeah, another tunable that no one knows how to use.
> 
> Really, why is this here at all?  As others pointed out, this really
> looks like a debugging thing that almost no one will ever need, so
> please, put it in debugfs.


Ok.

> 
> 
> Do the #ifdef in the .h file, not the .c file please, no matter how you
> end up doing this (debugfs vs. sysfs.)


Ok.

> 
> thanks,
> 
> greg k-h
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/