Re: [PATCH v3 4/7] x86/tlb: add tlb flush all factor for specificCPUs

[Alex Shi]

>

> This uses x86_model without qualifying it x86 (family), however that is
> meaningless.  All the CPUs you are dealing with above have c->x86 == 6,
> but you need to handle others correctly (even if that just means
> defaulting it to zero.)
> 
> One way to do that is to do:
> 
> switch ((c->x86 << 8) + c->x86_model) {
> 
> ... and use numbers like 0x62d instead of 45.


Yes, this is better, thanks!

> 
> 	-hpa
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/