Re: [GIT PULL 0/4] perf/annotate loop detection V2, fixes

[Peter Zijlstra]

On Fri, 2012-04-27 at 12:31 -0300, Arnaldo Carvalho de Melo wrote:
> > So the forward conditional jumps get moved by one character to 
> > the right and get prefixed with '.', which has the following 
> > effects:
> > 
> >  - the flow of all the 'other', register modifying and loop 
> >    instructions can be seen more clearly
> > 
> >  - the 'exception' forward conditional jumps get moved into the 
> >    visual background, slightly.
> > 
> >  - blocks of instructions with no branches amongst them are more 
> >    clearly visible.
> > 
> > If '.' is too aggressive or too confusing then some other 
> > (possibly graphical) character could be used as well?
> 
> Yeah, there are some unused graphical chars. But perhaps we should just
> use â again?
> 
>      0.00 ââââ c0:    cmp    %rax,%rbx
>      0.00 ââ          mov    %rax,%rcx
>      0.00 ââ      â   âje    5dd
>      0.00 ââ   cc:    test   %rcx,%rcx
>      0.00 ââ      â   âje    da
>      0.00 ââ          mov    0x8(%rcx),%esi
>      0.00 ââ          shr    $0x4,%esi
>      0.00 ââ          sub    $0x2,%esi
>      0.00 ââ   da:    mov    %rcx,0x10(%rbx)
>      0.00 ââ          mov    %rcx,%rax
>      0.00 ââ          cmpl   $0x0,%fs:0x18
>      0.00 ââ      â   âje    ed
>      0.00 ââ          lock   cmpxchg %rbx,(%rdx)
>      0.00 ââ          cmp    %rax,%rcx
>           ââ
>      0.00 âââââââââ } jne    c0
> 
> Does it still stands out? I think so, we expect a letter there,
> something very different is there, matching the other down arrowsome
> columns to the left. 

That just looks daft.. what's wrong with the single up/down arrow?

Also, can we keep all this on the list please?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/