Re: [PATCH 1/4] mfd: add LM3533 lighting-power core driver

[Mark Brown]

On Fri, Apr 20, 2012 at 05:30:23PM +0200, Johan Hovold wrote:

> +static int __lm3533_read(struct lm3533 *lm3533, u8 reg, u8 *val)
> +{
> +	int ret;
> +
> +	ret = lm3533->read(lm3533, reg, val);
> +	if (ret < 0) {

Looks like you could save a bunch of code by using regmap for the
register I/O.  This would also give you access to the cache and
diagnostic infrastructure it has.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/