Re: [PATCH] android: make persistent_ram based drivers depend on HAVE_MEMBLOCK

[Geert Uytterhoeven]

On Wed, Mar 21, 2012 at 18:18, Colin Cross <ccross@xxxxxxxxxxx> wrote:
> m68k doesn't have memblock_reserve, which causes a build failure
> with allmodconfig. ÂMake PERSISTENT_RAM and RAM_CONSOLE depend on
> HAVE_MEMBLOCK.
>
> Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Reported-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> Signed-off-by: Colin Cross <ccross@xxxxxxxxxxx>

Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

> ---
> Âdrivers/staging/android/Kconfig | Â Â3 ++-
> Â1 files changed, 2 insertions(+), 1 deletions(-)
>
> I can't test on m68k, but this disables the options if I remove
> HAVE_MEMBLOCK from arm.
>
> diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
> index 08a3b11..eb1dee2 100644
> --- a/drivers/staging/android/Kconfig
> +++ b/drivers/staging/android/Kconfig
> @@ -27,13 +27,14 @@ config ANDROID_LOGGER
>
> Âconfig ANDROID_PERSISTENT_RAM
> Â Â Â Âbool
> + Â Â Â depends on HAVE_MEMBLOCK
> Â Â Â Âselect REED_SOLOMON
> Â Â Â Âselect REED_SOLOMON_ENC8
> Â Â Â Âselect REED_SOLOMON_DEC8
>
> Âconfig ANDROID_RAM_CONSOLE
> Â Â Â Âbool "Android RAM buffer console"
> - Â Â Â depends on !S390 && !UML
> + Â Â Â depends on !S390 && !UML && HAVE_MEMBLOCK
> Â Â Â Âselect ANDROID_PERSISTENT_RAM
> Â Â Â Âdefault n

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/