Re: [PATCH] staging: android/ram_console: Don't build on arches w/o ioremap

[Geert Uytterhoeven]

On Tue, Feb 7, 2012 at 06:13, Anton Vorontsov
<anton.vorontsov@xxxxxxxxxx> wrote:
> This patch fixes UML build:
>
> Â ÂCC Â Â Âdrivers/staging/android/ram_console.o
> Âdrivers/staging/android/ram_console.c: In function
> Â'ram_console_driver_probe':
> Âdrivers/staging/android/ram_console.c:358:2: error: implicit declaration
> Âof function 'ioremap' [-Werror=implicit-function-declaration]
> Âcc1: some warnings being treated as errors
> Âmake[3]: *** [drivers/staging/android/ram_console.o] Error 1
>
> Signed-off-by: Anton Vorontsov <anton.vorontsov@xxxxxxxxxx>
> ---
> Âdrivers/staging/android/Kconfig | Â Â1 +
> Â1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
> index becf711..2054ccb 100644
> --- a/drivers/staging/android/Kconfig
> +++ b/drivers/staging/android/Kconfig
> @@ -27,6 +27,7 @@ config ANDROID_LOGGER
>
> Âconfig ANDROID_RAM_CONSOLE
> Â Â Â Âbool "Android RAM buffer console"
> + Â Â Â depends on !S390 && !UML

Shouldn't that be "depends on HAS_IOMEM" instead?
I guess it also break on tile, which is the third NO_IOMEM arch?

> Â Â Â Âdefault n

Superfluous, "n" is the default.

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/