Re: [PATCH 00/10] jump label: introduce very_[un]likely + cleanups+ docs

From: H. Peter Anvin
Date: Wed Feb 22 2012 - 10:09:59 EST


On 02/22/2012 12:18 AM, Ingo Molnar wrote:
>
> For example could you tell *at a glance* what this does:
>
> + if (!static_branch_def_false(&perf_sched_events.key))
>
> ?

Yes. Unlike

> + if (very_unlikely(&perf_sched_events.key))

... which is actively misleading.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/