Re: [PATCH 10/20] pinctrl: Assume map table entries can't have aNULL ctrl_dev_name field

[Dong Aisheng]

On Sun, Feb 19, 2012 at 11:45:50PM -0700, Stephen Warren wrote:
> These are already disallowed. Clean up some code that doesn't assume this.
> 
> Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx>
> ---
>  drivers/pinctrl/core.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
> index 331ffb6..37dfac7 100644
> --- a/drivers/pinctrl/core.c
> +++ b/drivers/pinctrl/core.c
> @@ -770,8 +770,7 @@ static int pinctrl_hog_maps(struct pinctrl_dev *pctldev)
>  
>  	mutex_lock(&pinctrl_maps_mutex);
>  	for_each_maps(maps_node, i, map) {
> -		if (map->ctrl_dev_name &&
> -		    !strcmp(map->ctrl_dev_name, devname) &&
> +		if (!strcmp(map->ctrl_dev_name, devname) &&
>  		    !strcmp(map->dev_name, devname)) {
>  			/* OK time to hog! */
>  			ret = pinctrl_hog_map(pctldev, map);
> -- 
> 1.7.5.4
> 

Acked-by: Dong Aisheng <dong.aisheng@xxxxxxxxxx>

Regards
Dong Aisheng

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/