Re: An extremely simplified pinctrl bindings proposal

From: Linus Walleij
Date: Mon Feb 06 2012 - 20:07:37 EST


On Tue, Feb 7, 2012 at 12:57 AM, Tony Lindgren <tony@xxxxxxxxxxx> wrote:

>> I'm not sure if I'm following completely, if this is inside the devicetree-based
>> driver file, would it work to just add a struct dentry * to the
>> pinctrl_desc where you put a per-driver file?
>
> I was thinking generic debufs entries for all drivers.

OK.

>> Or maybe add extern void pinctrl_add_debugfs(struct dentry *) that adds
>> a new file to the existing per-driver directory through the core and then
>> have this add that file?
>
> Sounds like you've thought it further than me already :)
>
> Maybe that's the way to go to solve the one register for
> multiple pins issue.
>
>> Or did you mean that the core.c should be register-aware?
>
> I was just thinking string name ignoring core.c, so that would
> be the pinctrl_add_debugfs() option then. Do you see problems
> with this approach?

No probs, something like that you call any number of times
after registering the core device should work fine I guess.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/