Re: [PATCH 3/5] ACPI: EC: Add a limited number of repeats after false EC interrupts

From: Andi Kleen
Date: Mon Feb 06 2012 - 13:01:04 EST

> Our EC code is, at this point, a layer of hacks piled on top of other
> hacks. We have various patches that fix some machines and break others
> and a lack of a detailed description of what the driver actually does
> and where it deviates from the specification (and why).

The moving to an interrupt thread will enable a lot of cleanups
in fact. A lot of the existing code could be simplified now that
you can sleep. A lot of the nasty code was simply a workaround
for that.

I don't have plans to work on this however, since my laptop
works now (sorry). But I believe the patchkit is a good base
for further cleanups.


ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at