Re: [PATCH 4/5] ACPI: Do cpufreq clamping for throttling per package v2

From: Andi Kleen
Date: Mon Feb 06 2012 - 12:59:21 EST


On Mon, Feb 06, 2012 at 04:31:06PM +0000, Matthew Garrett wrote:
> On Mon, Feb 06, 2012 at 08:17:11AM -0800, Andi Kleen wrote:
> > +#define reduction_pctg(cpu) \
> > + per_cpu(cpufreq_thermal_reduction_pctg, phys_package_first_cpu(cpu))
>
> I don't like using percentages here - we end up with the potential for

The code was using percentages before, i merely moved the accounting
to be per package. I don't disagree with changing them, but it
should be probably a separate patch.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/